fix: pass SCALER_BACKEND=keda to OpenShift E2E test step#979
fix: pass SCALER_BACKEND=keda to OpenShift E2E test step#979clubanderson wants to merge 1 commit intomainfrom
Conversation
The CI deploys infrastructure with SCALER_BACKEND=keda but the test step did not pass this env var. The test defaults to prometheus-adapter, causing it to query the external metrics API directly — KEDA returns 500 (not 404) for unknown metrics, which the test treats as a failure. With SCALER_BACKEND=keda set, the test correctly checks for ScaledObject resources instead of querying the external metrics API. Fixes #978 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Pull request overview
Updates the OpenShift E2E GitHub Actions workflow to ensure the E2E test run uses the same scaler backend (keda) as the infrastructure deployed earlier in the job, preventing tests from taking the wrong (prometheus-adapter) path on OpenShift.
Changes:
- Pass
SCALER_BACKEND: kedainto the “Run OpenShift E2E tests” step environment. - Print
SCALER_BACKENDin the step’s configuration log output for easier debugging.
| # Must match the scaler backend used during infrastructure deployment | ||
| SCALER_BACKEND: keda |
There was a problem hiding this comment.
SCALER_BACKEND is now hardcoded in multiple steps (infra deploy, Model B deploy, and this test step). To avoid future drift (e.g., changing the deploy backend but forgetting to update tests), consider defining SCALER_BACKEND: keda once at the job/workflow env: level and referencing it from each step, or reusing an existing ${{ env.SCALER_BACKEND }} value if you add one earlier.
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
|
@clubanderson |
Summary
SCALER_BACKEND: keda(line 697), but the "Run OpenShift E2E tests" step did not pass this env var to the testsprometheus-adapterand queries the external metrics API directly — KEDA serves that API and returns 500 for unknown metrics instead of 404NotFound(404), so it fails withInternalError(500)SCALER_BACKEND=kedaset, the test takes the KEDA-aware branch and checks forScaledObjectresources insteadFixes #978
Test plan
SCALER_BACKEND: kedaappears in the CI log output